Bug 128881

Summary:

setSelectionRange shouldn't directly instantiate VisibleSelection

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Forms

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

127832

Attachments:

Description	Flags
Fixes the bug	none

Description Ryosuke Niwa 2014-02-15 20:19:18 PST

This triggers synchronous layout.

Comment 1 Ryosuke Niwa 2014-02-15 20:20:05 PST

The scope of this bug is to encapsulate the instantiation of VisibleSelection into FrameSelection so that we may optimize them away later.

Comment 2 Ryosuke Niwa 2014-02-15 20:22:30 PST

Created attachment 224313 [details]
Fixes the bug

Comment 3 Andreas Kling 2014-02-16 13:24:27 PST

Comment on attachment 224313 [details]
Fixes the bug

r=me

Comment 4 WebKit Commit Bot 2014-02-16 13:55:11 PST

Comment on attachment 224313 [details]
Fixes the bug

Clearing flags on attachment: 224313

Committed r164194: <http://trac.webkit.org/changeset/164194>

Comment 5 WebKit Commit Bot 2014-02-16 13:55:13 PST

All reviewed patches have been landed.  Closing bug.