Bug 128879

Summary: DOMSelection shouldn't instantiate VisibleSelection everywhere
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, darin, enrica, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 127832    
Attachments:
Description Flags
Cleanup koivisto: review+

Ryosuke Niwa
Reported 2014-02-15 19:11:31 PST
Right now, various member functions of DOMSelection instantiates VisibleSelection. This would mean that all those functions are triggering synchronous layout at that point. Defer those synchronous layout until FrameSelection's member functions are called so that we may optimize them later in the bug 127832.
Attachments
Cleanup (6.21 KB, patch)
2014-02-15 19:13 PST, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-02-15 19:12:12 PST
This change is needed to increase the test coverage of asynchronous selection because we don't have that many tests for selection inside text fields.
Ryosuke Niwa
Comment 2 2014-02-15 19:13:11 PST
Created attachment 224307 [details] Cleanup
Ryosuke Niwa
Comment 3 2014-02-15 19:29:52 PST
Committed r164188: <http://trac.webkit.org/changeset/164188>
Note You need to log in before you can comment on or make changes to this bug.