Bug 128879

Summary: DOMSelection shouldn't instantiate VisibleSelection everywhere
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Severity: Normal CC: benjamin, darin, enrica, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 127832    
Description Flags
Cleanup koivisto: review+

Description Ryosuke Niwa 2014-02-15 19:11:31 PST
Right now, various member functions of DOMSelection instantiates VisibleSelection.
This would mean that all those functions are triggering synchronous layout at that point.

Defer those synchronous layout until FrameSelection's member functions are called
so that we may optimize them later in the bug 127832.
Comment 1 Ryosuke Niwa 2014-02-15 19:12:12 PST
This change is needed to increase the test coverage of asynchronous selection because we don't have that many tests for selection inside text fields.
Comment 2 Ryosuke Niwa 2014-02-15 19:13:11 PST
Created attachment 224307 [details]
Comment 3 Ryosuke Niwa 2014-02-15 19:29:52 PST
Committed r164188: <http://trac.webkit.org/changeset/164188>