Summary: | Setting currentTime on HTMLMediaElement with media controller should throw exception | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Piotr Grad <piotr.grad> | ||||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, sergio | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Piotr Grad
2014-02-15 00:58:41 PST
Created attachment 224296 [details]
Patch & layout test
Created attachment 224297 [details]
Patch & layout test
Comment on attachment 224297 [details] Patch & layout test View in context: https://bugs.webkit.org/attachment.cgi?id=224297&action=review > LayoutTests/media/video-controller-currentTime.html:7 > + function start() { Nit: a function's opening brace should be on a new line. > LayoutTests/media/video-controller-currentTime.html:13 > + function canPlayThrough() { Ditto. > LayoutTests/media/video-controller-currentTime.html:19 > + try { > + video.currentTime = 3; > + } catch (e) { > + consoleWrite(e); > + endTest(); > + } You should also test that an INVALID_STATE_ERR exception is thrown, eg.: testDOMException("video.currentTime = 3", "DOMException.INVALID_STATE_ERR"); Created attachment 224299 [details]
Patch & layout test
Comment on attachment 224299 [details]
Patch & layout test
Thank you!
Comment on attachment 224299 [details] Patch & layout test Clearing flags on attachment: 224299 Committed r164174: <http://trac.webkit.org/changeset/164174> All reviewed patches have been landed. Closing bug. Comment on attachment 224299 [details] Patch & layout test View in context: https://bugs.webkit.org/attachment.cgi?id=224299&action=review > Source/WebCore/html/HTMLMediaElement.h:183 > + virtual void setCurrentTime(double, ExceptionCode&); I see no reason for this function to be virtual. |