| Summary: | run-webkit-tests doesn't work with Apache 2.4 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
| Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ddkilzer, glenn, lforschler, matthew_hanson, mrobinson, ossy, slewis | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryosuke Niwa
2014-02-14 18:05:51 PST
Created attachment 224271 [details]
Fixes the bug
Comment on attachment 224271 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=224271&action=review > Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:144 > + # FIXME: This is such a hack but we can't invoke httpd in _path_to_apache_config_file. It would be helpful to explain why exactly this is a hack, and if there are any ideas for how to improve this in the future. This comment is not very useful as is - someone who understands why it's a hack doesn't need the comment to see that, and someone who doesn't won't get any benefit from it. > Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:149 > + if 'Apache/2.4' in process.stdout.read(): What about Apache 2.5+? Created attachment 224272 [details]
Fixes the bug
Comment on attachment 224272 [details]
Fixes the bug
rs=me
Committed r164148: <http://trac.webkit.org/changeset/164148> Fixed builds in http://trac.webkit.org/changeset/164149. Another one: http://trac.webkit.org/changeset/164150 |