Bug 128861

Summary: run-webkit-tests doesn't work with Apache 2.4
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, glenn, lforschler, matthew_hanson, mrobinson, ossy, slewis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Fixes the bug kling: review+

Ryosuke Niwa
Reported 2014-02-14 18:05:51 PST
run-webkit-tests doesn't work with Apache 2.4
Attachments
Fixes the bug (6.96 KB, patch)
2014-02-14 18:07 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixes the bug (6.32 KB, patch)
2014-02-14 18:24 PST, Ryosuke Niwa 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-02-14 18:07:23 PST
Created attachment 224271 [details] Fixes the bug
Alexey Proskuryakov
Comment 2 2014-02-14 18:12:30 PST
Comment on attachment 224271 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=224271&action=review > Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:144 > + # FIXME: This is such a hack but we can't invoke httpd in _path_to_apache_config_file. It would be helpful to explain why exactly this is a hack, and if there are any ideas for how to improve this in the future. This comment is not very useful as is - someone who understands why it's a hack doesn't need the comment to see that, and someone who doesn't won't get any benefit from it. > Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:149 > + if 'Apache/2.4' in process.stdout.read(): What about Apache 2.5+?
Ryosuke Niwa
Comment 3 2014-02-14 18:24:14 PST
Created attachment 224272 [details] Fixes the bug
Andreas Kling
Comment 4 2014-02-14 18:27:20 PST
Comment on attachment 224272 [details] Fixes the bug rs=me
Ryosuke Niwa
Comment 5 2014-02-14 18:34:16 PST
Committed r164148: <http://trac.webkit.org/changeset/164148>
Ryosuke Niwa
Comment 6 2014-02-14 18:45:22 PST
Fixed builds in http://trac.webkit.org/changeset/164149.
Ryosuke Niwa
Comment 7 2014-02-14 18:47:29 PST
Another one: http://trac.webkit.org/changeset/164150
Note You need to log in before you can comment on or make changes to this bug.