Bug 128859

Summary:

[Win] Avoid unnecessary asserts if "prepareToPlay" called multiple times

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Media

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Brent Fulgham 2014-02-14 17:49:01 PST

There seem to be some use cases where the HTMLMediaElement may call "prepareToPlay" more than once. This could happen if asset metadata arrives earlier than expected, or if a web page makes the call multiple times.

Instead of asserting when this happens, just return the existing player item.

Comment 1 Brent Fulgham 2014-02-14 17:50:45 PST

Created attachment 224268 [details]
Patch

Comment 2 WebKit Commit Bot 2014-02-15 11:20:40 PST

Comment on attachment 224268 [details]
Patch

Clearing flags on attachment: 224268

Committed r164177: <http://trac.webkit.org/changeset/164177>

Comment 3 WebKit Commit Bot 2014-02-15 11:20:43 PST

All reviewed patches have been landed.  Closing bug.