Bug 128859

Summary: [Win] Avoid unnecessary asserts if "prepareToPlay" called multiple times
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2014-02-14 17:49:01 PST
There seem to be some use cases where the HTMLMediaElement may call "prepareToPlay" more than once. This could happen if asset metadata arrives earlier than expected, or if a web page makes the call multiple times. Instead of asserting when this happens, just return the existing player item.
Attachments
Patch (2.11 KB, patch)
2014-02-14 17:50 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-02-14 17:50:45 PST
Created attachment 224268 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-15 11:20:40 PST
Comment on attachment 224268 [details] Patch Clearing flags on attachment: 224268 Committed r164177: <http://trac.webkit.org/changeset/164177>
WebKit Commit Bot
Comment 3 2014-02-15 11:20:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.