| Summary: | [Win] Make tests more consistent with Mac platform | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Brent Fulgham
2014-02-14 15:17:22 PST
Created attachment 224259 [details]
Patch
Comment on attachment 224259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224259&action=review > Source/WebKit/win/WebPreferences.h:484 > + virtual HRESULT STDMETHODCALLTYPE screenFontSubstitutionEnabled(BOOL*); > + virtual HRESULT STDMETHODCALLTYPE setScreenFontSubstitutionEnabled(BOOL); I'm not sure this one has any effect on Windows. > Source/WebKit/win/WebView.cpp:5058 > + hr = prefsPrivate->screenFontSubstitutionEnabled(&enabled); > + if (FAILED(hr)) > + return hr; > + settings.setScreenFontSubstitutionEnabled(enabled); I think this is a no-op. > Tools/DumpRenderTree/win/DumpRenderTree.cpp:876 > + preferences->setCSSRegionsEnabled(TRUE); Does this mean we can enable a bunch of tests? Landed in http://trac.webkit.org/changeset/164141. |