Summary: | Expose a way to clear cookies modified after a given date | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ricky Mondello <rmondello> | ||||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, berto, cdumez, cgarcia, commit-queue, danw, galpeter, gustavo, jberlin, mrobinson, ossy | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Ricky Mondello
2014-02-14 14:22:07 PST
Created attachment 224269 [details]
Patch
Created attachment 224273 [details]
Does this fix the GTK build?
Comment on attachment 224273 [details] Does this fix the GTK build? View in context: https://bugs.webkit.org/attachment.cgi?id=224273&action=review One of the reasons the GTK and EFL builds are broken is that you added a method declaration to PlatformCookieJar.h but only added an implementation to Source/WebCore/platform/network/cf/CookieJarCFNet.cpp and Source/WebCore/platform/network/mac/CookieJarMac.mm. You also need to add a stub implementation to the soup/CookieJarSoup.cpp implementation and possibly to the curl/CookieJarCurl.cpp implementation. > Source/WebCore/platform/network/cf/CookieJarCFNet.cpp:242 > +void deleteAllCookies(const NetworkStorageSession&) This is one of the reasons the Windows build is broken: 1>..\platform\network\cf\CookieJarCFNet.cpp(243): error C2084: function 'void WebCore::deleteAllCookies(const WebCore::NetworkStorageSession &)' already has a body C:\cygwin\home\buildbot\WebKit\Source\WebCore\platform\network\PlatformCookieJar.h(50) : see previous definition of 'deleteAllCookies' You probably meant void deleteAllCookiesModifiedAfterDate(const NetworkStorageSession&, double) instead Created attachment 224421 [details]
Addressing Jessie's feedback
Comment on attachment 224421 [details] Addressing Jessie's feedback View in context: https://bugs.webkit.org/attachment.cgi?id=224421&action=review > Source/WebCore/platform/network/mac/CookieJarMac.mm:42 > +@interface NSHTTPCookieStorage () I thought that we used named categories for these things: @interface NSHTTPCookieStorage (Details) (In reply to comment #5) > (From update of attachment 224421 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=224421&action=review > > > Source/WebCore/platform/network/mac/CookieJarMac.mm:42 > > +@interface NSHTTPCookieStorage () > > I thought that we used named categories for these things: > > @interface NSHTTPCookieStorage (Details) We do and should! I'll post another patch. Created attachment 224461 [details]
Same as the last patch, but name the category
Comment on attachment 224461 [details] Same as the last patch, but name the category Clearing flags on attachment: 224461 Committed r164272: <http://trac.webkit.org/changeset/164272> |