| Summary: | [CSS Regions] visibility: hidden on a region should hide its content | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andrei Bucur <abucur> | ||||||||
| Component: | WebCore Misc. | Assignee: | Andrei Bucur <abucur> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, WebkitBugTracker | ||||||||
| Priority: | P2 | Keywords: | AdobeTracked | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 57312 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 224217 [details]
Patch
Comment on attachment 224217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224217&action=review > LayoutTests/fast/regions/visibility-hidden-expected.html:5 > + <meta http-equiv="content-type" content="text/html; charset=UTF-8"> Please remove this meta tag. > LayoutTests/fast/regions/visibility-hidden.html:5 > + <meta http-equiv="content-type" content="text/html; charset=UTF-8"> Ditto. > LayoutTests/fast/regions/visibility-hidden.html:11 > + border: 1px solid red; Do you need the region to have dimensions and border for this test? > LayoutTests/fast/regions/visibility-hidden.html:16 > + margin-top: 0px; Why do you margin-top on this? I doubt that you need it. Created attachment 224219 [details]
Patch
Comment on attachment 224219 [details]
Patch
r=me
Comment on attachment 224219 [details] Patch Clearing flags on attachment: 224219 Committed r164103: <http://trac.webkit.org/changeset/164103> All reviewed patches have been landed. Closing bug. |
Created attachment 224211 [details] Test case See the attached test case.