Summary: | setSelectionRange shouldn't trigger a synchronous layout to check focusability when text field is already focused | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Forms | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, benjamin, commit-queue, darin, enrica, kling, koivisto | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 127832 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2014-02-14 01:02:31 PST
We can get rid of synchronous layout completely once we fix webkit.org/b/38696 as I've outlined in https://lists.webkit.org/pipermail/webkit-dev/2014-February/026235.html but we can fix this one first in order to resolve the bug 128797 since we don't call setSelectionRange in setValue when the text field is not focused. Created attachment 224186 [details]
Fixes the bug
Attachment 224186 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:19: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 224186 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=224186&action=review > Source/WebCore/ChangeLog:19 > + already. Also pass in DoNotSetFocus option to setSelection since we already have the focus in that case. Odd. I thought I removed this tab character before uploading it :/ Comment on attachment 224186 [details]
Fixes the bug
Looks good.
Committed r164156: <http://trac.webkit.org/changeset/164156> |