|Summary:||setSelectionRange shouldn't trigger a synchronous layout to check focusability when text field is already focused|
|Product:||WebKit||Reporter:||Ryosuke Niwa <rniwa>|
|Component:||Forms||Assignee:||Ryosuke Niwa <rniwa>|
|Severity:||Normal||CC:||barraclough, benjamin, commit-queue, darin, enrica, kling, koivisto|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Ryosuke Niwa 2014-02-14 01:02:31 PST
HTMLTextFormControl::setSelectionRange doesn't need to trigger a synchronous layout if the text field is already focused since we don't need to call hasVisibleTextArea in that case, which depends on the dimension of RenderBox.
Comment 1 Ryosuke Niwa 2014-02-14 01:04:03 PST
We can get rid of synchronous layout completely once we fix webkit.org/b/38696 as I've outlined in https://lists.webkit.org/pipermail/webkit-dev/2014-February/026235.html but we can fix this one first in order to resolve the bug 128797 since we don't call setSelectionRange in setValue when the text field is not focused.
Comment 3 WebKit Commit Bot 2014-02-14 02:38:14 PST
Attachment 224186 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:19: Line contains tab character. [whitespace/tab]  Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ryosuke Niwa 2014-02-14 12:55:05 PST
Comment on attachment 224186 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=224186&action=review > Source/WebCore/ChangeLog:19 > + already. Also pass in DoNotSetFocus option to setSelection since we already have the focus in that case. Odd. I thought I removed this tab character before uploading it :/
Comment 5 Enrica Casucci 2014-02-14 14:29:48 PST
Comment on attachment 224186 [details] Fixes the bug Looks good.