Bug 128798

Summary: Use CXX instead of CC for preprocessor
Product: WebKit Reporter: Ting-Wei Lan <lantw44>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: cdumez, cgarcia, commit-queue, esprehn+autocc, kangil.han, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Replace CC with CXX none

Ting-Wei Lan
Reported 2014-02-13 23:06:38 PST
In Source/WebCore/bindings/scripts/preprocessor.pm and Source/WebCore/dom/make_names.pl, we use -x c++ to make sure the C preprocessor is running in C++ mode. This cause problem if the user set CC with options which is not available in C++, such as "clang -std=c11". We should use CXX instead for preprocessor, so -x c++ will not cause problem.
Attachments
Replace CC with CXX (2.54 KB, patch)
2014-02-13 23:08 PST, Ting-Wei Lan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ting-Wei Lan
Comment 1 2014-02-13 23:08:49 PST
Created attachment 224165 [details] Replace CC with CXX
Zan Dobersek
Comment 2 2014-02-16 02:41:31 PST
Compiler flags should be placed into CFLAGS and CXXFLAGS environment variables.
Ting-Wei Lan
Comment 3 2014-02-24 22:25:58 PST
We shuold not assume the C compiler is the same as the C++ compiler.
Note You need to log in before you can comment on or make changes to this bug.