Bug 128772

Summary: GetByIdStatus shouldn't call takesSlowPathInDFGForImpureProperty() for self accesses, and calling that method should never assert about anything
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED WONTFIX    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mhahnenberg: review+

Filip Pizlo
Reported 2014-02-13 15:13:11 PST
Patch forthcoming
Attachments
the patch (2.90 KB, patch)
2014-02-13 15:14 PST, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-13 15:14:03 PST
Created attachment 224118 [details] the patch
Mark Hahnenberg
Comment 2 2014-02-13 15:16:23 PST
Comment on attachment 224118 [details] the patch r=me
Filip Pizlo
Comment 3 2014-02-13 15:27:24 PST
Landed in http://trac.webkit.org/changeset/164066
Filip Pizlo
Comment 4 2014-02-13 15:49:01 PST
This is wrong. Rolling it out.
Filip Pizlo
Comment 5 2014-02-13 16:31:51 PST
Rolled out in http://trac.webkit.org/changeset/164071
Note You need to log in before you can comment on or make changes to this bug.