Bug 128772

Summary:

GetByIdStatus shouldn't call takesSlowPathInDFGForImpureProperty() for self accesses, and calling that method should never assert about anything

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mhahnenberg: review+

Description Filip Pizlo 2014-02-13 15:13:11 PST

Patch forthcoming

Comment 1 Filip Pizlo 2014-02-13 15:14:03 PST

Created attachment 224118 [details]
the patch

Comment 2 Mark Hahnenberg 2014-02-13 15:16:23 PST

Comment on attachment 224118 [details]
the patch

r=me

Comment 3 Filip Pizlo 2014-02-13 15:27:24 PST

Landed in http://trac.webkit.org/changeset/164066

Comment 4 Filip Pizlo 2014-02-13 15:49:01 PST

This is wrong.  Rolling it out.

Comment 5 Filip Pizlo 2014-02-13 16:31:51 PST

Rolled out in http://trac.webkit.org/changeset/164071