Bug 128772 - GetByIdStatus shouldn't call takesSlowPathInDFGForImpureProperty() for self accesses, and calling that method should never assert about anything
Summary: GetByIdStatus shouldn't call takesSlowPathInDFGForImpureProperty() for self a...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-13 15:13 PST by Filip Pizlo
Modified: 2014-02-13 16:31 PST (History)
7 users (show)

See Also:

Attachments
the patch (2.90 KB, patch)
2014-02-13 15:14 PST, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-13 15:13:11 PST 
Patch forthcoming
Comment 1 Filip Pizlo 2014-02-13 15:14:03 PST 
Created attachment 224118 [details]
the patch
Comment 2 Mark Hahnenberg 2014-02-13 15:16:23 PST 
Comment on attachment 224118 [details]
the patch

r=me
Comment 3 Filip Pizlo 2014-02-13 15:27:24 PST 
Landed in http://trac.webkit.org/changeset/164066
Comment 4 Filip Pizlo 2014-02-13 15:49:01 PST 
This is wrong.  Rolling it out.
Comment 5 Filip Pizlo 2014-02-13 16:31:51 PST 
Rolled out in http://trac.webkit.org/changeset/164071