Bug 128771 – SVG - Filtered element will be upscaled with low filterRes value

• Component: SVG
• Status: RESOLVED WONTFIX

[Adenilson Cavalcanti Silva]

Should appear as a green rectangle, will display 2 rectangles (one being red at the background).

[Adenilson Cavalcanti Silva]

Created attachment 224117 [details]
PoC: should appear as a single green rectangle

[Adenilson Cavalcanti Silva]

Created attachment 224668 [details]
Patch

[WebKit Commit Bot]

Attachment 224668 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:12:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dirk Schulze]

Comment on attachment 224668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224668&action=review

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:171
> +    // If the scale factor is way too low, it will deform/upscale the
> +    // element size.

filterRes is used by internal code as well to make sure we do nor create to big buffers. Does the issue happen for internal code as well? If not, we should rather remove the API from SVGFitlerElement. It already was removed from Fitler Effects specification.

[Adenilson Cavalcanti Silva]

Dirk

Thanks for the review.

When you mentioned "internal code" and "big buffers", are you referring to that function that tests for maximumImageSize (i.e. bool RenderSVGResourceFilter::fitsInMaximumImageSize(const FloatSize& size, FloatSize& scale)? If so, scale factor is not tested there.

Or are you talking about other code path?

[Adenilson Cavalcanti Silva]

Dirk

As you have pointed, the spec will drop the filterRes parameter and it seems that FF has dropped it already.

Should I instead created a new bug to propose removal of this feature?

[Dirk Schulze]

(In reply to comment #6)
> Dirk
> 
> As you have pointed, the spec will drop the filterRes parameter and it seems that FF has dropped it already.
> 
> Should I instead created a new bug to propose removal of this feature?

yes please. :)

[Adenilson Cavalcanti Silva]

The followup bug:
https://bugs.webkit.org/show_bug.cgi?id=129565

[Dirk Schulze]

Can we close this bug now?

[Csaba Osztrogonác]

Comment on attachment 224668 [details]
Patch

Cleared review? from attachment 224668 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).