Bug 12877

Summary: "Contributing Code" page could be clearer
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit WebsiteAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: ddkilzer
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
URL: http://webkit.org/coding/contributing.html
Attachments:
Description Flags
Contributing cleanup darin: review+

Mark Rowe (bdash)
Reported 2007-02-24 03:54:35 PST
The Contributing Code page could be a lot clearer in what steps are involved in submitting a patch for the first time. It is currently a 15+ paragraph page that meanders through the requirements. It would be more direct to list the requirements for contributions (small distinct changes that meet the coding style guidlelines, ChangeLog entry generated by prepare-ChangeLog, patch created with "svn diff"/svn-create-patch), and how to go about getting it into the tree. Making this clearer would make it easier for new-comers to understand the relatively strict requirements we have for patch submission.
Attachments
Contributing cleanup (11.84 KB, patch)
2007-03-19 16:06 PDT, Matt Lilek 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Lilek
Comment 1 2007-03-19 16:06:12 PDT
Created attachment 13708 [details] Contributing cleanup Cleans up the contribution page. Adds a quick list of steps with more information later on. Adds info on WebKitTools/Scripts so that each mention of a script doesn't need to have the full path, etc (would that section make more sense at the top?). This also takes care of bug 8690.
Darin Adler
Comment 2 2007-03-19 20:40:45 PDT
Comment on attachment 13708 [details] Contributing cleanup looks fine, r=me
Mark Rowe (bdash)
Comment 3 2007-03-20 18:01:58 PDT
Landed in r20354.
Note You need to log in before you can comment on or make changes to this bug.