Bug 12877 - "Contributing Code" page could be clearer
Summary: "Contributing Code" page could be clearer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P2 Major
Assignee: Nobody
URL: http://webkit.org/coding/contributing...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-24 03:54 PST by Mark Rowe (bdash)
Modified: 2007-03-20 18:01 PDT (History)
1 user (show)

See Also:


Attachments
Contributing cleanup (11.84 KB, patch)
2007-03-19 16:06 PDT, Matt Lilek
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2007-02-24 03:54:35 PST
The Contributing Code page could be a lot clearer in what steps are involved in submitting a patch for the first time.  It is currently a 15+ paragraph page that meanders through the requirements.  It would be more direct to list the requirements for contributions (small distinct changes that meet the coding style guidlelines, ChangeLog entry generated by prepare-ChangeLog, patch created with "svn diff"/svn-create-patch), and how to go about getting it into the tree.  Making this clearer would make it easier for new-comers to understand the relatively strict requirements we have for patch submission.
Comment 1 Matt Lilek 2007-03-19 16:06:12 PDT
Created attachment 13708 [details]
Contributing cleanup

Cleans up the contribution page.  Adds a quick list of steps with more information later on.  Adds info on WebKitTools/Scripts so that each mention of a script doesn't need to have the full path, etc (would that section make more sense at the top?).

This also takes care of bug 8690.
Comment 2 Darin Adler 2007-03-19 20:40:45 PDT
Comment on attachment 13708 [details]
Contributing cleanup

looks fine, r=me
Comment 3 Mark Rowe (bdash) 2007-03-20 18:01:58 PDT
Landed in r20354.