Bug 128752

Summary: Add rendering progress events SPI
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2014-02-13 11:56:39 PST
Add rendering progress events SPI
Attachments
Patch (13.82 KB, patch)
2014-02-13 12:12 PST, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-02-13 12:12:21 PST
Created attachment 224092 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-13 12:15:08 PST
Attachment 224092 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:30: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:40: Missing spaces around = [whitespace/operators] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2014-02-13 13:06:44 PST
Comment on attachment 224092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224092&action=review > Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:372 > + [static_cast<id<WKNavigationDelegatePrivate>>(navigationDelegate.get()) _webView:m_navigationState.m_webView renderingProgressDidChange:renderingProgressEvents(layoutMilestones)]; Missing space after “id”
Anders Carlsson
Comment 4 2014-02-13 13:09:14 PST
Committed r164049: <http://trac.webkit.org/changeset/164049>
Note You need to log in before you can comment on or make changes to this bug.