Bug 128750

Summary:

AX: Move the ~400 lines #defines in WebAccessibilityObjectWrapperMac.mm to a separate file.

Product:

WebKit

Reporter:

Samuel White <samuel_white>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, darin, dino, dmazzoni, ews-watchlist, graouts, jcraig, jdiggs, kondapallykalyan, webkit-bug-importer, yevseytsev

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.9

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	darin: review-

Description Samuel White 2014-02-13 10:32:43 PST

We have over 400 lines of attribute and parameterized attribute related defines at the top of WebAccessibilityObjectWrapperMac.mm (and growing). We should move these to a separate file and group/label them a bit better.

Comment 1 Radar WebKit Bug Importer 2014-02-13 10:33:19 PST

<rdar://problem/16060611>

Comment 2 yevseytsev 2019-04-05 09:47:13 PDT

Created attachment 366819 [details]
Patch

Comment 3 EWS Watchlist 2019-04-05 09:50:03 PDT

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Comment 4 EWS Watchlist 2019-04-05 09:50:14 PDT

Attachment 366819 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 yevseytsev 2019-04-05 10:04:52 PDT

Created attachment 366820 [details]
Patch

Comment 6 EWS Watchlist 2019-04-05 10:08:49 PDT

Attachment 366820 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 yevseytsev 2019-04-05 10:32:45 PDT

Created attachment 366826 [details]
Patch

Comment 8 Darin Adler 2019-04-05 11:52:34 PDT

Comment on attachment 366826 [details]
Patch

This patch has a lot of unrelated changes. Please submit another without them.

Also, please give a rationale for why moving these lines is a good idea. The title of a bug typically needs to answer the question "why?" as well as just saying what’s changing.

Comment 9 chris fleizach 2019-04-05 12:53:07 PDT

Comment on attachment 366819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366819&action=review

> Source/WebCore/ChangeLog:10
> +        * accessibility/mac/WebAccessibilityObjectWrapperMac.h:

there's no need to put these #defines in a header that others import. they're only used inside this mm

Comment 10 yevseytsev 2019-04-17 16:22:27 PDT

Oh, I see, if this "bug" do not need to be fixed anymore can anybody please change its status to "CLOSED"? I started to work on it because I saw a status "NEW"