Bug 128719

Summary: No need to save reservedZoneSize when dropping the JSLock
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. ggaren: review+

Description Mark Lam 2014-02-12 19:39:08 PST 
The reservedZoneSize does not change due to the VM being run on a different thread.  Hence, there is no need to save and restore its value.  Instead of calling updateReservedZoneSize() to update the stack limit, we now call updateStackPointerAtVMEntry() to do the job.  updateStackPointerAtVMEntry() will update the stackPointerAtVMEntry and delegate to updateStackLimit() to update the stack limit based on the new stackPointerAtVMEntry.
Comment 1 Mark Lam 2014-02-12 19:49:52 PST 
Created attachment 224043 [details]
the patch.
Comment 2 Geoffrey Garen 2014-02-12 22:30:50 PST 
Comment on attachment 224043 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=224043&action=review

r=me

> Source/JavaScriptCore/runtime/VM.cpp:735
> +void VM::updateStackPointerAtVMEntry(void* sp)

This should be named "setStackPointerAtVMEntry".
Comment 3 Mark Lam 2014-02-12 22:46:04 PST 
Thanks for the review.  The patch has been updated and landed in r164018: <http://trac.webkit.org/r164018>.