Bug 128711

Summary: IDB: TestExpectations batch - "data-corruption.html to duplicates.html"
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch v1 ap: review+, beidson: commit-queue-

Brady Eidson
Reported 2014-02-12 17:44:25 PST
IDB: TestExpectations batch - "data-corruption.html to duplicates.html"
Attachments
Patch v1 (7.96 KB, patch)
2014-02-12 17:52 PST, Brady Eidson 		ap: review+
beidson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-02-12 17:52:29 PST
Created attachment 224036 [details] Patch v1
Brady Eidson
Comment 2 2014-02-12 19:36:40 PST
This doesn't apply because it relies on 123706 first.
Alexey Proskuryakov
Comment 3 2014-02-12 19:55:53 PST
Comment on attachment 224036 [details] Patch v1 rs=me. I prefer explicit [ Skip ] expectations, because they make it clear that these entries are not ancient one from the times we could only skip, and skipped everything that was flaky. Not entirely sure why these patches need to go through Bugzilla.
Brady Eidson
Comment 4 2014-02-12 20:21:45 PST
(In reply to comment #3) > (From update of attachment 224036 [details]) > rs=me. > > I prefer explicit [ Skip ] expectations, because they make it clear that these entries are not ancient one from the times we could only skip, and skipped everything that was flaky. Sounds reasonable. > > Not entirely sure why these patches need to go through Bugzilla. Sounds like an implicit rs=me for the next few batches! :)
Brady Eidson
Comment 5 2014-02-12 21:25:47 PST
http://trac.webkit.org/changeset/164012
Note You need to log in before you can comment on or make changes to this bug.