Bug 128711 - IDB: TestExpectations batch - "data-corruption.html to duplicates.html"
Summary: IDB: TestExpectations batch - "data-corruption.html to duplicates.html"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 17:44 PST by Brady Eidson
Modified: 2014-02-12 21:25 PST (History)
1 user (show)

See Also:


Attachments
Patch v1 (7.96 KB, patch)
2014-02-12 17:52 PST, Brady Eidson
ap: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-12 17:44:25 PST
IDB: TestExpectations batch - "data-corruption.html to duplicates.html"
Comment 1 Brady Eidson 2014-02-12 17:52:29 PST
Created attachment 224036 [details]
Patch v1
Comment 2 Brady Eidson 2014-02-12 19:36:40 PST
This doesn't apply because it relies on 123706 first.
Comment 3 Alexey Proskuryakov 2014-02-12 19:55:53 PST
Comment on attachment 224036 [details]
Patch v1

rs=me.

I prefer explicit [ Skip ] expectations, because they make it clear that these entries are not ancient one from the times we could only skip, and skipped everything that was flaky.

Not entirely sure why these patches need to go through Bugzilla.
Comment 4 Brady Eidson 2014-02-12 20:21:45 PST
(In reply to comment #3)
> (From update of attachment 224036 [details])
> rs=me.
> 
> I prefer explicit [ Skip ] expectations, because they make it clear that these entries are not ancient one from the times we could only skip, and skipped everything that was flaky.

Sounds reasonable.

> 
> Not entirely sure why these patches need to go through Bugzilla.

Sounds like an implicit rs=me for the next few batches!  :)
Comment 5 Brady Eidson 2014-02-12 21:25:47 PST
http://trac.webkit.org/changeset/164012