| Summary: | <rdar://problem/15994340> WK2: Cannot scroll to the bottom of the page when the keyboard is on the screen | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, enrica, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2014-02-12 17:42:39 PST
Created attachment 224032 [details]
Patch
Comment on attachment 224032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224032&action=review Looks good to me, > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:353 > + // FIXME: We will also need to adjust the unobscured rect by taking into account the keyboard rect and the obsucred insets. typo: obscured > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:360 > + if ([_contentView isAssistingNode]) Maybe you should add a comment explaining that this is the way you figure out that the notification is for this view. > Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:290 > + // FIXME: We will also need to adjust the unobscured rect by taking into account the keyboard rect and the obsucred insets. Same typo. Committed r164120: <http://trac.webkit.org/changeset/164120> |