Bug 128710 - <rdar://problem/15994340> WK2: Cannot scroll to the bottom of the page when the keyboard is on the screen
Summary: <rdar://problem/15994340> WK2: Cannot scroll to the bottom of the page when t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 17:42 PST by Benjamin Poulain
Modified: 2014-02-14 12:48 PST (History)
3 users (show)

See Also:

Attachments
Patch (11.04 KB, patch)
2014-02-12 17:44 PST, Benjamin Poulain 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-02-12 17:42:39 PST 
<rdar://problem/15994340> WK2: Cannot scroll to the bottom of the page when the keyboard is on the screen
Comment 1 Benjamin Poulain 2014-02-12 17:44:15 PST 
Created attachment 224032 [details]
Patch
Comment 2 Enrica Casucci 2014-02-14 12:40:34 PST 
Comment on attachment 224032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224032&action=review

Looks good to me,

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:353
> +    // FIXME: We will also need to adjust the unobscured rect by taking into account the keyboard rect and the obsucred insets.

typo: obscured

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:360
> +    if ([_contentView isAssistingNode])

Maybe you should add a comment explaining that this is the way you figure out that the notification is for this view.

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:290
> +    // FIXME: We will also need to adjust the unobscured rect by taking into account the keyboard rect and the obsucred insets.

Same typo.
Comment 3 Benjamin Poulain 2014-02-14 12:48:10 PST 
Committed r164120: <http://trac.webkit.org/changeset/164120>