Bug 128707

Summary:

Add relatedWebView property to WKWebViewConfiguration

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	mitz: review+

Description Anders Carlsson 2014-02-12 17:24:24 PST

Add relatedWebView property to WKWebViewConfiguration

Comment 1 Anders Carlsson 2014-02-12 17:25:36 PST

Created attachment 224029 [details]
Patch

Comment 2 Anders Carlsson 2014-02-12 17:29:10 PST

Created attachment 224030 [details]
Patch

Comment 3 Anders Carlsson 2014-02-12 17:43:33 PST

Created attachment 224031 [details]
Patch

Comment 4 WebKit Commit Bot 2014-02-12 17:45:08 PST

Attachment 224031 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:34:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 mitz 2014-02-12 17:46:35 PST

Comment on attachment 224031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224031&action=review

> Source/WebKit2/ChangeLog:14
> +        * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm.

It’s weird to copy the header from a source file.

Comment 6 Anders Carlsson 2014-02-12 17:49:21 PST

Committed r164004: <http://trac.webkit.org/changeset/164004>