| Summary: | Make code generation of the unoptimized pseudo classes separate | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | kling | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2014-02-12 16:33:25 PST
Created attachment 224027 [details]
Patch
Comment on attachment 224027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224027&action=review r=me > Source/WebCore/cssjit/SelectorCompiler.cpp:908 > + for (unsigned i = 0; i < fragment.unoptimizedPseudoClasses.size(); ++i) Range for? (In reply to comment #2) > > Source/WebCore/cssjit/SelectorCompiler.cpp:908 > > + for (unsigned i = 0; i < fragment.unoptimizedPseudoClasses.size(); ++i) > > Range for? They generate bad code for going over arrays. I avoid them until clang is fixed :) Comment on attachment 224027 [details] Patch Clearing flags on attachment: 224027 Committed r164118: <http://trac.webkit.org/changeset/164118> All reviewed patches have been landed. Closing bug. |