Bug 128701

Summary: [EFL][WK1] Do not include libsoup header in the public headers
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2014-02-12 16:00:22 PST
Although ewebkit used libsoup internally, it's not good for EFL developers to use it.
Attachments
Patch (8.35 KB, patch)
2014-02-12 16:05 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (8.77 KB, patch)
2014-02-12 16:12 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-02-12 16:05:05 PST
Created attachment 224022 [details] Patch
Ryuan Choi
Comment 2 2014-02-12 16:12:03 PST
Created attachment 224023 [details] Patch
Gyuyoung Kim
Comment 3 2014-02-12 16:37:09 PST
Comment on attachment 224023 [details] Patch Basically, I agree not to open libsoup header in ewk header. However, it would be good to replace those APIs with new wrapper APIs together.
Ryuan Choi
Comment 4 2014-02-12 16:59:20 PST
(In reply to comment #3) > (From update of attachment 224023 [details]) > Basically, I agree not to open libsoup header in ewk header. However, it would be good to replace those APIs with new wrapper APIs together. Basically, I think that it is wrong approach to expose session directly. In my opinion, we'd better to expose proper APIs like ewk_view_proxy_uri_set instead of exposing setter/getter of session and letting application developers learn extra libraries.
Gyuyoung Kim
Comment 5 2014-02-12 17:08:37 PST
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 224023 [details] [details]) > > Basically, I agree not to open libsoup header in ewk header. However, it would be good to replace those APIs with new wrapper APIs together. > > Basically, I think that it is wrong approach to expose session directly. > > In my opinion, we'd better to expose proper APIs like ewk_view_proxy_uri_set instead of exposing setter/getter of session and letting application developers learn extra libraries. Yes, I meant that it is nice to remove those APIs with new wrapper APIs together.
Gyuyoung Kim
Comment 6 2014-02-13 00:13:55 PST
Comment on attachment 224023 [details] Patch As we talked, we believe that this APIs aren't being used now. So, let's remove it. r=me.
Ryuan Choi
Comment 7 2014-02-13 04:50:33 PST
Comment on attachment 224023 [details] Patch Thanks.
WebKit Commit Bot
Comment 8 2014-02-13 05:20:21 PST
Comment on attachment 224023 [details] Patch Clearing flags on attachment: 224023 Committed r164028: <http://trac.webkit.org/changeset/164028>
WebKit Commit Bot
Comment 9 2014-02-13 05:20:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.