Bug 128698 – REGRESSION: Crashing/Broken Tests Due To Unexpected 8-bit Character Data

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Brent Fulgham]

The code change in http://trac.webkit.org/changeset/127801, coupled with the recent change to turn on 8-bit character use everywhere caused the Windows build to break.

Windows API only accepts 16-bit Unicode strings for certain operations. The 8-bit strings being passed around inside WebKit need to be converted to 16-bit when calling these APIs.

[Brent Fulgham]

Created attachment 224014 [details]
Patch

[Tim Horton]

Comment on attachment 224014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224014&action=review

> Source/WebCore/platform/graphics/win/UniscribeController.cpp:111
> +    String tempToHold16BitCopy;

"temp" not so great

[Brent Fulgham]

(In reply to comment #2)
> (From update of attachment 224014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224014&action=review
> 
> > Source/WebCore/platform/graphics/win/UniscribeController.cpp:111
> > +    String tempToHold16BitCopy;
> 
> "temp" not so great

Changing to bufferFor16BitData.

[Brent Fulgham]

Committed r164001: <http://trac.webkit.org/changeset/164001>

[Radar WebKit Bug Importer]

<rdar://problem/16054890>