Bug 128698

Summary: REGRESSION: Crashing/Broken Tests Due To Unexpected 8-bit Character Data
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Major CC: andersca, bfulgham, mitz, msaboff, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 95812    
Bug Blocks:    
Attachments:
Description Flags
Patch thorton: review+

Description Brent Fulgham 2014-02-12 15:02:27 PST 
The code change in http://trac.webkit.org/changeset/127801, coupled with the recent change to turn on 8-bit character use everywhere caused the Windows build to break.

Windows API only accepts 16-bit Unicode strings for certain operations. The 8-bit strings being passed around inside WebKit need to be converted to 16-bit when calling these APIs.
Comment 1 Brent Fulgham 2014-02-12 15:04:55 PST 
Created attachment 224014 [details]
Patch
Comment 2 Tim Horton 2014-02-12 15:10:58 PST 
Comment on attachment 224014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224014&action=review

> Source/WebCore/platform/graphics/win/UniscribeController.cpp:111
> +    String tempToHold16BitCopy;

"temp" not so great
Comment 3 Brent Fulgham 2014-02-12 15:38:17 PST 
(In reply to comment #2)
> (From update of attachment 224014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224014&action=review
> 
> > Source/WebCore/platform/graphics/win/UniscribeController.cpp:111
> > +    String tempToHold16BitCopy;
> 
> "temp" not so great

Changing to bufferFor16BitData.
Comment 4 Brent Fulgham 2014-02-12 17:22:25 PST 
Committed r164001: <http://trac.webkit.org/changeset/164001>
Comment 5 Radar WebKit Bug Importer 2014-02-12 17:23:42 PST 
<rdar://problem/16054890>