Bug 128698 - REGRESSION: Crashing/Broken Tests Due To Unexpected 8-bit Character Data
Summary: REGRESSION: Crashing/Broken Tests Due To Unexpected 8-bit Character Data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Major
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 95812
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-12 15:02 PST by Brent Fulgham
Modified: 2014-02-12 17:23 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.61 KB, patch)
2014-02-12 15:04 PST, Brent Fulgham 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-02-12 15:02:27 PST 
The code change in http://trac.webkit.org/changeset/127801, coupled with the recent change to turn on 8-bit character use everywhere caused the Windows build to break.

Windows API only accepts 16-bit Unicode strings for certain operations. The 8-bit strings being passed around inside WebKit need to be converted to 16-bit when calling these APIs.
Comment 1 Brent Fulgham 2014-02-12 15:04:55 PST 
Created attachment 224014 [details]
Patch
Comment 2 Tim Horton 2014-02-12 15:10:58 PST 
Comment on attachment 224014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224014&action=review

> Source/WebCore/platform/graphics/win/UniscribeController.cpp:111
> +    String tempToHold16BitCopy;

"temp" not so great
Comment 3 Brent Fulgham 2014-02-12 15:38:17 PST 
(In reply to comment #2)
> (From update of attachment 224014 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224014&action=review
> 
> > Source/WebCore/platform/graphics/win/UniscribeController.cpp:111
> > +    String tempToHold16BitCopy;
> 
> "temp" not so great

Changing to bufferFor16BitData.
Comment 4 Brent Fulgham 2014-02-12 17:22:25 PST 
Committed r164001: <http://trac.webkit.org/changeset/164001>
Comment 5 Radar WebKit Bug Importer 2014-02-12 17:23:42 PST 
<rdar://problem/16054890>