| Summary: | Web Inspector: Get InspectorIndexedDBAgent working | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, beidson, commit-queue, graouts, joepeck, jsbell, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2014-02-12 14:04:49 PST
Created attachment 224010 [details]
Patch
Comment on attachment 224010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224010&action=review > Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:62 > +typedef HashMap<String, HashSet<String>> IDBRecentDatabaseNameMap; > + > +static IDBRecentDatabaseNameMap& sharedRecentDatabaseNameMap() There's been a recent growing backlash against typedefs for maps like these. I know there's some in the IDB code already. Please don't add this new one :) > Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:129 > + ASSERT(!securityOriginIdentifier.isNull()); s/isNull/isEmpty/ Comment on attachment 224010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224010&action=review > Source/WebCore/ChangeLog:18 > + Make DOMStringList.h private some WebKit2 can use it. Typo: "some" => "so" > Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:100 > + callbacks->onError(IDBDatabaseError::create(IDBDatabaseException::InvalidAccessError, "Document is not allowed to use Indexed Databases")); Nit: You could use ASCIILiteral for the Error string. |