Bug 128677

Summary: Clean up PageThrottler interface
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebCore Misc.Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, japhet, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix benjamin: review+

Gavin Barraclough
Reported 2014-02-12 11:16:11 PST
Currently, responsibility for throttling DOM timers & suspending animations is split between the Page & the PageThrottler. Clarify by making Page responsible for suspending animations (PageThrottler is now purely related to aspects of timer throttling), and move all timer throttling policy to the PageThrottler, with a single function on Page to enable (Page::setTimerThrottlingEnabled). Also, transmit the full ViewState to the PageThrottler (not just the IsVisuallyIdle flag), and distinguish between media & page-load activity.
Attachments
Fix (18.61 KB, patch)
2014-02-12 11:53 PST, Gavin Barraclough 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2014-02-12 11:53:20 PST
Created attachment 223989 [details] Fix
WebKit Commit Bot
Comment 2 2014-02-12 11:55:52 PST
Attachment 223989 [details] did not pass style-queue: ERROR: Source/WebCore/page/PageThrottler.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2014-02-12 13:51:33 PST
Transmitting file data .......... Committed revision 163983.
Note You need to log in before you can comment on or make changes to this bug.