Bug 12865

Summary: More gdk's notImplemented() macro improvements
Product: WebKit Reporter: Krzysztof Kowalczyk <kkowalczyk>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: PC   
OS: OS X 10.4   
Attachments:
Description Flags
improvements to notImplemented() macro usage
aroben: review+
forgot to set svn:eol-style aroben: review+

Krzysztof Kowalczyk
Reported 2007-02-22 22:42:56 PST
More gdk's notImplemented() macro improvements
Attachments
improvements to notImplemented() macro usage (16.60 KB, patch)
2007-02-22 22:44 PST, Krzysztof Kowalczyk 		aroben: review+
DetailsFormatted DiffDiff
forgot to set svn:eol-style (16.76 KB, patch)
2007-02-22 22:50 PST, Krzysztof Kowalczyk 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Krzysztof Kowalczyk
Comment 1 2007-02-22 22:44:16 PST
Created attachment 13341 [details] improvements to notImplemented() macro usage To avoid code duplication, move notImplementedGdk() macro to a separate header file. Remove existing notImplementedGdk() macros and replace remaining notImplemented() to notImplementedGdk() in gdk code.
Adam Roben (:aroben)
Comment 2 2007-02-22 22:49:50 PST
Comment on attachment 13341 [details] improvements to notImplemented() macro usage Index: WebCore/platform/gdk/NotImplementedGdk.h You should set svn:eol-style native on this new file. r=me
Krzysztof Kowalczyk
Comment 3 2007-02-22 22:50:00 PST
Created attachment 13342 [details] forgot to set svn:eol-style Like before but with svn:eol-style set to native for newly added file.
Adam Roben (:aroben)
Comment 4 2007-02-22 22:51:54 PST
Comment on attachment 13342 [details] forgot to set svn:eol-style Haha, you read my mind. r=me again!
Krzysztof Kowalczyk
Comment 5 2007-02-22 23:01:37 PST
landed in r19822
Note You need to log in before you can comment on or make changes to this bug.