| Summary: | Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Farler <dfarler> | ||||
| Component: | Tools / Tests | Assignee: | David Farler <dfarler> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dbates, ddkilzer, dmazzoni, jcraig, jdiggs, mario, samuel_white, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | iPhone / iPad | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
David Farler
2014-02-11 13:41:28 PST
Created attachment 224906 [details]
Patch
Comment on attachment 224906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224906&action=review I would suggesting doing the test result move in a separate commit from the script changes. > Tools/Scripts/old-run-webkit-tests:130 > -sub installAndLaunchDumpRenderTreeAppUsingNotification($$); > +sub installAndLaunchDumpToolAppUsingNotification($$); I think you could use "TestRunnerApp" as the generic term. (In reply to comment #2) > (From update of attachment 224906 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=224906&action=review > > I would suggesting doing the test result move in a separate commit from the script changes. Sounds good. We were planning to scrap the results anyway and start over. See: https://bugs.webkit.org/show_bug.cgi?id=129171 > > > Tools/Scripts/old-run-webkit-tests:130 > > -sub installAndLaunchDumpRenderTreeAppUsingNotification($$); > > +sub installAndLaunchDumpToolAppUsingNotification($$); > > I think you could use "TestRunnerApp" as the generic term. I don't think we need to test this ORWT change with Mac, since ORWT can only parse Skipped files or Test Expections files where each line is only a test path and assumes that any listing in either of those files is a "skip". It does look like win-cairo uses this kind of TestExpectation file (one test path per line), however. Committed r164506: <http://trac.webkit.org/changeset/164506> *** Bug 127693 has been marked as a duplicate of this bug. *** |