Summary: | need to #include <libgen.h> for basename | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Allison Lortie (desrt) <desrt> | ||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | berto, cgarcia, commit-queue, landry | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 128598 | ||||||||||
Attachments: |
|
Description
Allison Lortie (desrt)
2014-02-11 05:57:26 PST
Same issue on OpenBSD, fixed by http://www.openbsd.org/cgi-bin/cvsweb/ports/www/webkit/patches/patch-Source_WebKit2_PluginProcess_unix_PluginProcessMainUnix_cpp?rev=1.1 Dunno if the #include has to be os-specific... The header is POSIX-specified, so it should definitely not be made OS-specific. Comment on attachment 223845 [details] Be sure to #include <libgen.h> for basename Please add a ChangeLog, as described at <http://www.webkit.org/coding/contributing.html>. Either you or someone else has to make a ChangeLog entry for landing. Created attachment 225088 [details]
Patch
(In reply to comment #4) > Created an attachment (id=225088) [details] > Patch Yeah, thinks looks good, thanks a lot! Created attachment 225359 [details]
Patch
Comment on attachment 225359 [details] Patch Clearing flags on attachment: 225359 Committed r164797: <http://trac.webkit.org/changeset/164797> All reviewed patches have been landed. Closing bug. |