Bug 128582

Summary:

Stop using PLATFORM(MAC) in WebKit2/Shared except where it means “OS X but not iOS”

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Replace PLATFORM(MAC)	darin: review+

Description mitz 2014-02-10 23:15:58 PST

Same deal as bug 128513.

Comment 1 mitz 2014-02-10 23:28:31 PST

Created attachment 223815 [details]
Replace PLATFORM(MAC)

Comment 2 Darin Adler 2014-02-11 09:31:40 PST

Comment on attachment 223815 [details]
Replace PLATFORM(MAC)

View in context: https://bugs.webkit.org/attachment.cgi?id=223815&action=review

> Source/WebKit2/Shared/NativeWebKeyboardEvent.h:47
> +#if PLATFORM(GTK)
>  #include <WebCore/CompositionResults.h>
>  #include <WebCore/GUniquePtrGtk.h>
>  #include <WebCore/GtkInputMethodFilter.h>
>  typedef union _GdkEvent GdkEvent;
> -#elif PLATFORM(EFL)
> +#endif
> +
> +#if PLATFORM(EFL)
>  #include <Evas.h>
>  #endif

I would put EFL before GTK because I like alphabetical order rather than arbitrary order for such things.

Comment 3 mitz 2014-02-11 09:56:00 PST

Committed <http://trac.webkit.org/r163886>.