Bug 128581

Summary: IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1
ap: review+
Patch for landing none

Description Brady Eidson 2014-02-10 22:20:33 PST
IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs

Index gets don't return the key path, triggering this assert.  Simple fix.
Comment 1 Radar WebKit Bug Importer 2014-02-10 22:21:07 PST
<rdar://problem/16034112>
Comment 2 Brady Eidson 2014-02-10 22:36:58 PST
Created attachment 223811 [details]
Patch v1
Comment 3 Alexey Proskuryakov 2014-02-10 23:00:41 PST
Comment on attachment 223811 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=223811&action=review

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:936
> +    // We must return it to know how to inject the result key into the result value object.

s/it/a key path/
Comment 4 Brady Eidson 2014-02-11 07:44:16 PST
Created attachment 223862 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2014-02-11 08:22:45 PST
Comment on attachment 223862 [details]
Patch for landing

Clearing flags on attachment: 223862

Committed r163877: <http://trac.webkit.org/changeset/163877>
Comment 6 WebKit Commit Bot 2014-02-11 08:22:48 PST
All reviewed patches have been landed.  Closing bug.