Summary: | messages.py doesn't handle parameters with more than one level of scope. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||
Component: | WebKit2 | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jonlee, mmaxfield, rniwa, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 128564 | ||||||||
Attachments: |
|
Description
Jeremy Jones
2014-02-10 19:02:20 PST
Created attachment 223788 [details]
Patch
File "/Volumes/Data/Code/WebKit/OpenSource/Source/WebKit2/Scripts/webkit2/messages.py", line 473, in headers_for_type TypeError: not all arguments converted during string formatting headers.append('<%s/%s.h>' % tuple(split)) Comment on attachment 223788 [details]
Patch
You should probably add a test for this. There are tests in the same directory.
(In reply to comment #3) > (From update of attachment 223788 [details]) > You should probably add a test for this. There are tests in the same directory. Thanks. I'll do that. Created attachment 223888 [details]
Patch
Comment on attachment 223888 [details] Patch Clearing flags on attachment: 223888 Committed r164171: <http://trac.webkit.org/changeset/164171> All reviewed patches have been landed. Closing bug. |