Bug 128571

Summary: Make it possible to run tests with --llvmSimpleOpt=false
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch mark.lam: review+

Description Filip Pizlo 2014-02-10 18:28:38 PST 
This will give us coverage for when we run the full LLVM optimization pipeline.  Running that full pipeline shouldn't break anything.  It's good for us to know that there is no such thing as an LLVM optimization phase that breaks our assumptions.
Comment 1 Filip Pizlo 2014-02-10 18:31:02 PST 
Created attachment 223783 [details]
the patch
Comment 2 Mark Lam 2014-02-10 18:37:53 PST 
Comment on attachment 223783 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223783&action=review

> Tools/Scripts/run-jsc-stress-tests:582
> +def runFTLNoSimpleOpt
> +    run("ftl-no-simple-opt", "--enableConcurrentJIT=false", "--llvmSimpleOpt=false", *FTL_OPTIONS) if $enableFTL
> +end

I don’t see runFTLNoSimpleOpt referenced anywhere else.  Is this intentional?
Comment 3 Filip Pizlo 2014-02-10 18:38:18 PST 
(In reply to comment #2)
> (From update of attachment 223783 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223783&action=review
> 
> > Tools/Scripts/run-jsc-stress-tests:582
> > +def runFTLNoSimpleOpt
> > +    run("ftl-no-simple-opt", "--enableConcurrentJIT=false", "--llvmSimpleOpt=false", *FTL_OPTIONS) if $enableFTL
> > +end
> 
> I don’t see runFTLNoSimpleOpt referenced anywhere else.  Is this intentional?

Yes.
Comment 4 Mark Lam 2014-02-10 18:38:54 PST 
Comment on attachment 223783 [details]
the patch

r=me
Comment 5 Filip Pizlo 2014-02-10 18:41:13 PST 
Landed in http://trac.webkit.org/changeset/163852