Bug 128571

Summary: Make it possible to run tests with --llvmSimpleOpt=false
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112840    
Attachments:
Description Flags
the patch mark.lam: review+

Filip Pizlo
Reported 2014-02-10 18:28:38 PST
This will give us coverage for when we run the full LLVM optimization pipeline. Running that full pipeline shouldn't break anything. It's good for us to know that there is no such thing as an LLVM optimization phase that breaks our assumptions.
Attachments
the patch (6.23 KB, patch)
2014-02-10 18:31 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-02-10 18:31:02 PST
Created attachment 223783 [details] the patch
Mark Lam
Comment 2 2014-02-10 18:37:53 PST
Comment on attachment 223783 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=223783&action=review > Tools/Scripts/run-jsc-stress-tests:582 > +def runFTLNoSimpleOpt > + run("ftl-no-simple-opt", "--enableConcurrentJIT=false", "--llvmSimpleOpt=false", *FTL_OPTIONS) if $enableFTL > +end I don’t see runFTLNoSimpleOpt referenced anywhere else. Is this intentional?
Filip Pizlo
Comment 3 2014-02-10 18:38:18 PST
(In reply to comment #2) > (From update of attachment 223783 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223783&action=review > > > Tools/Scripts/run-jsc-stress-tests:582 > > +def runFTLNoSimpleOpt > > + run("ftl-no-simple-opt", "--enableConcurrentJIT=false", "--llvmSimpleOpt=false", *FTL_OPTIONS) if $enableFTL > > +end > > I don’t see runFTLNoSimpleOpt referenced anywhere else. Is this intentional? Yes.
Mark Lam
Comment 4 2014-02-10 18:38:54 PST
Comment on attachment 223783 [details] the patch r=me
Filip Pizlo
Comment 5 2014-02-10 18:41:13 PST
Landed in http://trac.webkit.org/changeset/163852
Note You need to log in before you can comment on or make changes to this bug.