| Summary: | Remove a couple of deprecatedCharacters() from WebKit2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, commit-queue, g.czajkowski, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 128580, 128603 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2014-02-10 17:58:35 PST
Created attachment 223780 [details]
Patch
Committed r163848: <http://trac.webkit.org/changeset/163848> Looks like you broke the iOS build again :( Re-opened since this is blocked by bug 128580 This change caused a lot of crashes on tests, http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r163858%20(3106)/results.html In debug builds, it asserts like this: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x0000000109d1071a WTFCrash + 42 (Assertions.cpp:333) 1 com.apple.JavaScriptCore 0x0000000109d68ddd WTF::String::fromUTF8(unsigned char const*, unsigned long) + 61 (WTFString.cpp:835) 2 com.apple.JavaScriptCore 0x0000000109d6911f WTF::String::fromUTF8WithLatin1Fallback(unsigned char const*, unsigned long) + 47 (WTFString.cpp:871) 3 WebKitTestRunnerInjectedBundle 0x000000011385c274 WTF::String::fromUTF8WithLatin1Fallback(char const*, unsigned long) + 36 (WTFString.h:429) 4 WebKitTestRunnerInjectedBundle 0x000000011385c088 WTR::toWTFString(OpaqueWKString const*) + 216 (StringFunctions.h:91) 5 WebKitTestRunnerInjectedBundle 0x000000011385940f WTR::toWTFString(WebKit::WKRetainPtr<OpaqueWKString const*> const&) + 47 (StringFunctions.h:96) 6 WebKitTestRunnerInjectedBundle 0x000000011387e185 WTR::dumpFrameText(OpaqueWKBundleFrame const*, WTF::StringBuilder&) + 85 (InjectedBundlePage.cpp:781) 7 WebKitTestRunnerInjectedBundle 0x000000011387e6e9 WTR::InjectedBundlePage::dump() + 713 (InjectedBundlePage.cpp:853) 8 WebKitTestRunnerInjectedBundle 0x000000011387de27 WTR::InjectedBundlePage::frameDidChangeLocation(OpaqueWKBundleFrame const*, bool) + 199 (InjectedBundlePage.cpp:1887) 9 WebKitTestRunnerInjectedBundle 0x000000011387c8a6 WTR::InjectedBundlePage::didFinishLoadForFrame(OpaqueWKBundleFrame const*) + 118 (InjectedBundlePage.cpp:894) 10 WebKitTestRunnerInjectedBundle 0x000000011387b648 WTR::InjectedBundlePage::didFinishLoadForFrame(OpaqueWKBundlePage const*, OpaqueWKBundleFrame const*, void const**, void const*) + 40 (InjectedBundlePage.cpp:550) 11 com.apple.WebKit2 0x000000010777f7c6 WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame(WebKit::WebPage*, WebKit::WebFrame*, WTF::RefPtr<API::Object>&) + 118 (InjectedBundlePageLoaderClient.cpp:141) Is someone fixing? Should we revert? The bots are stuck since everything crashes. (In reply to comment #7) > Is someone fixing? Should we revert? > The bots are stuck since everything crashes. Cool, Alexey took care of it. Comment on attachment 223780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223780&action=review > Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:301 > + auto textString = stringView.createNSStringWithoutCopying(); Why keep the local variable? I would get rid of it. Feel free to commit EFL bits (bug 128603) after re-land. There is no deprecatedCharacters in WebKit2 now, maybe bug130197 removed the last bits. |