Summary: | Stop throwing when attempting to read instance properties directly from the prototype | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||||||
Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | alecflett, buildbot, cdumez, cgarcia, commit-queue, jsbell, mark.lam, mkwst, rniwa | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Oliver Hunt
2014-02-10 17:21:32 PST
Created attachment 223776 [details]
Patch
Comment on attachment 223776 [details]
Patch
r=me. Are we recording which websites have this weirdness so that we can determine if we can clean this up at some point in the future?
Comment on attachment 223776 [details] Patch Attachment 223776 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4733062348800000 New failing tests: js/dom/dom-attributes-on-mismatch-type.html Created attachment 223784 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 223776 [details] Patch Attachment 223776 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6318540265095168 New failing tests: js/dom/dom-attributes-on-mismatch-type.html Created attachment 223822 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 223776 [details] Patch Attachment 223776 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5976817097768960 New failing tests: js/dom/dom-attributes-on-mismatch-type.html Created attachment 223823 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 223776 [details] Patch Attachment 223776 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4665764506238976 New failing tests: js/dom/dom-attributes-on-mismatch-type.html Created attachment 223829 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Committed r163890: <http://trac.webkit.org/changeset/163890> Looks like this patch improved html5-full-render loading time by 1.5%-3%: https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mountainlion%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22mac-mavericks%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D |