Bug 128568 - Stop throwing when attempting to read instance properties directly from the prototype
Summary: Stop throwing when attempting to read instance properties directly from the p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-10 17:21 PST by Oliver Hunt
Modified: 2014-02-12 17:45 PST (History)
9 users (show)

See Also:

Attachments
Patch (98.17 KB, patch)
2014-02-10 17:24 PST, Oliver Hunt 		mark.lam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (1017.25 KB, application/zip)
2014-02-10 18:33 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (610.37 KB, application/zip)
2014-02-11 00:47 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (577.25 KB, application/zip)
2014-02-11 00:55 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (485.79 KB, application/zip)
2014-02-11 01:55 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2014-02-10 17:21:32 PST 
Stop throwing when attempting to read instance properties directly from the prototype
Comment 1 Oliver Hunt 2014-02-10 17:24:48 PST 
Created attachment 223776 [details]
Patch
Comment 2 Mark Lam 2014-02-10 18:15:15 PST 
Comment on attachment 223776 [details]
Patch

r=me.  Are we recording which websites have this weirdness so that we can determine if we can clean this up at some point in the future?
Comment 3 Build Bot 2014-02-10 18:33:05 PST 
Comment on attachment 223776 [details]
Patch

Attachment 223776 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4733062348800000

New failing tests:
js/dom/dom-attributes-on-mismatch-type.html
Comment 4 Build Bot 2014-02-10 18:33:07 PST 
Created attachment 223784 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-02-11 00:47:06 PST 
Comment on attachment 223776 [details]
Patch

Attachment 223776 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6318540265095168

New failing tests:
js/dom/dom-attributes-on-mismatch-type.html
Comment 6 Build Bot 2014-02-11 00:47:09 PST 
Created attachment 223822 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-02-11 00:55:04 PST 
Comment on attachment 223776 [details]
Patch

Attachment 223776 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5976817097768960

New failing tests:
js/dom/dom-attributes-on-mismatch-type.html
Comment 8 Build Bot 2014-02-11 00:55:08 PST 
Created attachment 223823 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 Build Bot 2014-02-11 01:55:45 PST 
Comment on attachment 223776 [details]
Patch

Attachment 223776 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4665764506238976

New failing tests:
js/dom/dom-attributes-on-mismatch-type.html
Comment 10 Build Bot 2014-02-11 01:55:48 PST 
Created attachment 223829 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 11 Oliver Hunt 2014-02-11 10:54:28 PST 
Committed r163890: <http://trac.webkit.org/changeset/163890>