WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128568
Stop throwing when attempting to read instance properties directly from the prototype
https://bugs.webkit.org/show_bug.cgi?id=128568
Summary
Stop throwing when attempting to read instance properties directly from the p...
Oliver Hunt
Reported
2014-02-10 17:21:32 PST
Stop throwing when attempting to read instance properties directly from the prototype
Attachments
Patch
(98.17 KB, patch)
2014-02-10 17:24 PST
,
Oliver Hunt
mark.lam
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
(1017.25 KB, application/zip)
2014-02-10 18:33 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
(610.37 KB, application/zip)
2014-02-11 00:47 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
(577.25 KB, application/zip)
2014-02-11 00:55 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
(485.79 KB, application/zip)
2014-02-11 01:55 PST
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2014-02-10 17:24:48 PST
Created
attachment 223776
[details]
Patch
Mark Lam
Comment 2
2014-02-10 18:15:15 PST
Comment on
attachment 223776
[details]
Patch r=me. Are we recording which websites have this weirdness so that we can determine if we can clean this up at some point in the future?
Build Bot
Comment 3
2014-02-10 18:33:05 PST
Comment on
attachment 223776
[details]
Patch
Attachment 223776
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/4733062348800000
New failing tests: js/dom/dom-attributes-on-mismatch-type.html
Build Bot
Comment 4
2014-02-10 18:33:07 PST
Created
attachment 223784
[details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 5
2014-02-11 00:47:06 PST
Comment on
attachment 223776
[details]
Patch
Attachment 223776
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/6318540265095168
New failing tests: js/dom/dom-attributes-on-mismatch-type.html
Build Bot
Comment 6
2014-02-11 00:47:09 PST
Created
attachment 223822
[details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 7
2014-02-11 00:55:04 PST
Comment on
attachment 223776
[details]
Patch
Attachment 223776
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/5976817097768960
New failing tests: js/dom/dom-attributes-on-mismatch-type.html
Build Bot
Comment 8
2014-02-11 00:55:08 PST
Created
attachment 223823
[details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 9
2014-02-11 01:55:45 PST
Comment on
attachment 223776
[details]
Patch
Attachment 223776
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/4665764506238976
New failing tests: js/dom/dom-attributes-on-mismatch-type.html
Build Bot
Comment 10
2014-02-11 01:55:48 PST
Created
attachment 223829
[details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Oliver Hunt
Comment 11
2014-02-11 10:54:28 PST
Committed
r163890
: <
http://trac.webkit.org/changeset/163890
>
Ryosuke Niwa
Comment 12
2014-02-12 17:45:06 PST
Looks like this patch improved html5-full-render loading time by 1.5%-3%:
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mountainlion%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22mac-mavericks%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug