Bug 128565

Summary:

[WK2] Add support for image document viewport configuration

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Benjamin Poulain 2014-02-10 16:31:35 PST

[WK2] Add support for image document viewport configuration

Comment 1 Benjamin Poulain 2014-02-10 16:33:16 PST

Created attachment 223768 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-02-10 16:36:51 PST

Comment on attachment 223768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223768&action=review

> Source/WebCore/page/ViewportConfiguration.h:87
> +    static Parameters imageParameters();

I'd call these textDocumentParamters, imageDocumentParameters.

> Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm:269
>  IntPoint PageClientImpl::screenToWindow(const IntPoint& point)
>  {
> -    notImplemented();
> -    return IntPoint();
> +    return IntPoint([m_view convertPoint:point fromView:nil]);
>  }
>  
>  IntRect PageClientImpl::windowToScreen(const IntRect& rect)
>  {
> -    notImplemented();
> -    return IntRect();
> +    return enclosingIntRect([m_view convertRect:rect toView:nil]);
>  }

Are these changes related to the patch?

Comment 3 Benjamin Poulain 2014-02-10 17:05:37 PST

Committed r163839: <http://trac.webkit.org/changeset/163839>