Bug 128548

Summary: Crash in copyShortASCIIString after r163793
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: Web Template FrameworkAssignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Enrica Casucci
Reported 2014-02-10 12:05:11 PST
A null check is missing. It happens in iOS.
Attachments
Patch (1.29 KB, patch)
2014-02-10 12:06 PST, Enrica Casucci 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2014-02-10 12:06:34 PST
Created attachment 223733 [details] Patch
Alexey Proskuryakov
Comment 2 2014-02-10 12:20:59 PST
Comment on attachment 223733 [details] Patch r=me, however would addressing Darin's FIXME fix this in a better way? // FIXME: Documentation claims the code above would work on iOS 4.0 and later. After test that works, we should remove this and use that instead.
Enrica Casucci
Comment 3 2014-02-10 13:05:15 PST
(In reply to comment #2) > (From update of attachment 223733 [details]) > r=me, however would addressing Darin's FIXME fix this in a better way? > > // FIXME: Documentation claims the code above would work on iOS 4.0 and later. After test that works, we should remove this and use that instead. I'm not sure about it. The code existed before and was performing a null check.
Alexey Proskuryakov
Comment 4 2014-02-10 15:33:28 PST
Enrica landed this patch in <http://trac.webkit.org/changeset/163809>.
Note You need to log in before you can comment on or make changes to this bug.