Bug 128548

Summary:

Crash in copyShortASCIIString after r163793

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

Web Template Framework

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Description Enrica Casucci 2014-02-10 12:05:11 PST

A null check is missing.
It happens in iOS.

Comment 1 Enrica Casucci 2014-02-10 12:06:34 PST

Created attachment 223733 [details]
Patch

Comment 2 Alexey Proskuryakov 2014-02-10 12:20:59 PST

Comment on attachment 223733 [details]
Patch

r=me, however would addressing Darin's FIXME fix this in a better way?

// FIXME: Documentation claims the code above would work on iOS 4.0 and later. After test that works, we should remove this and use that instead.

Comment 3 Enrica Casucci 2014-02-10 13:05:15 PST

(In reply to comment #2)
> (From update of attachment 223733 [details])
> r=me, however would addressing Darin's FIXME fix this in a better way?
> 
> // FIXME: Documentation claims the code above would work on iOS 4.0 and later. After test that works, we should remove this and use that instead.
I'm not sure about it. The code existed before and was performing a null check.

Comment 4 Alexey Proskuryakov 2014-02-10 15:33:28 PST

Enrica landed this patch in <http://trac.webkit.org/changeset/163809>.