Bug 128546

Summary: [MSE] Fix layering violations in MediaSource
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: b.long, cgarcia, commit-queue, eric.carlson, esprehn+autocc, glenn, gustavo, gyuyoung.kim, menard, mrobinson, philipj, pnormand, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch eric.carlson: review+

Jer Noble
Reported 2014-02-10 11:43:59 PST
[MSE] Fix layering violations in MediaSource
Attachments
Patch (3.40 KB, patch)
2014-02-10 11:58 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (39.28 KB, patch)
2014-02-10 12:01 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-02-10 11:58:43 PST
Created attachment 223730 [details] Patch
Jer Noble
Comment 2 2014-02-10 12:01:16 PST
Created attachment 223732 [details] Patch
Eric Carlson
Comment 3 2014-02-10 13:01:17 PST
Comment on attachment 223732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223732&action=review > Source/WebCore/platform/graphics/MediaPlayer.cpp:395 > +bool MediaPlayer::load(const URL& url, const ContentType& contentType, MediaSourcePrivateClient* mediaSource) > { > m_mediaSource = mediaSource; Nit: I think it is worth adding an ASSERT because you now take a raw pointer.
Jer Noble
Comment 4 2014-02-10 14:04:39 PST
Committed r163816: <http://trac.webkit.org/changeset/163816>
Brendan Long
Comment 5 2014-02-10 15:20:03 PST
This seems to have broken the GTK and EFL builds. Is removing HTMLMediaSource from CMakeLists.txt and GNUMakefile.list.am enough, or do we need to add any new files?
Jer Noble
Comment 6 2014-02-10 15:41:49 PST
(In reply to comment #5) > This seems to have broken the GTK and EFL builds. Is removing HTMLMediaSource from CMakeLists.txt and GNUMakefile.list.am enough, or do we need to add any new files? My apologies. No, the only new file is a non-exported header only.
Brendan Long
Comment 7 2014-02-10 15:48:04 PST
No worries, fixed now: http://trac.webkit.org/changeset/163826 http://trac.webkit.org/changeset/163828
Note You need to log in before you can comment on or make changes to this bug.