| Summary: | [MSE] Fix layering violations in MediaSource | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | b.long, cgarcia, commit-queue, eric.carlson, esprehn+autocc, glenn, gustavo, gyuyoung.kim, menard, mrobinson, philipj, pnormand, sergio | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jer Noble
2014-02-10 11:43:59 PST
Created attachment 223730 [details]
Patch
Created attachment 223732 [details]
Patch
Comment on attachment 223732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223732&action=review > Source/WebCore/platform/graphics/MediaPlayer.cpp:395 > +bool MediaPlayer::load(const URL& url, const ContentType& contentType, MediaSourcePrivateClient* mediaSource) > { > m_mediaSource = mediaSource; Nit: I think it is worth adding an ASSERT because you now take a raw pointer. Committed r163816: <http://trac.webkit.org/changeset/163816> This seems to have broken the GTK and EFL builds. Is removing HTMLMediaSource from CMakeLists.txt and GNUMakefile.list.am enough, or do we need to add any new files? (In reply to comment #5) > This seems to have broken the GTK and EFL builds. Is removing HTMLMediaSource from CMakeLists.txt and GNUMakefile.list.am enough, or do we need to add any new files? My apologies. No, the only new file is a non-exported header only. No worries, fixed now: http://trac.webkit.org/changeset/163826 http://trac.webkit.org/changeset/163828 |