Bug 128536

Summary: [wk2] REGRESSION (r162710): Open tab urls not restored after switching to new Safari build
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, ddkilzer, mrowe
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
darin: review+
patch
none
flipped a condition none

Tim Horton
Reported 2014-02-10 09:19:36 PST
http://trac.webkit.org/changeset/162710 changed the WebBackForwardListCF serialization without providing a way to import sessions in the old format. <rdar://problem/15911839>
Attachments
patch (11.25 KB, patch)
2014-02-10 10:25 PST, Tim Horton 		darin: review+
DetailsFormatted DiffDiff
patch (3.25 KB, patch)
2014-02-19 11:45 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
flipped a condition (3.25 KB, patch)
2014-02-19 11:53 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-02-10 10:25:05 PST
Created attachment 223723 [details] patch
Tim Horton
Comment 2 2014-02-10 17:05:40 PST
Anders comments that he thinks we should just do the revert of CurrentSessionStateDataVersion and not fail the import if a SnapshotUUID doesn't exist, instead of bumping sessionHistoryCurrentVersion.
Tim Horton
Comment 3 2014-02-19 11:45:30 PST
Created attachment 224660 [details] patch
Tim Horton
Comment 4 2014-02-19 11:53:36 PST
Created attachment 224661 [details] flipped a condition
WebKit Commit Bot
Comment 5 2014-02-19 12:39:29 PST
Comment on attachment 224661 [details] flipped a condition Clearing flags on attachment: 224661 Committed r164381: <http://trac.webkit.org/changeset/164381>
WebKit Commit Bot
Comment 6 2014-02-19 12:39:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.