Bug 128536 - [wk2] REGRESSION (r162710): Open tab urls not restored after switching to new Safari build
Summary: [wk2] REGRESSION (r162710): Open tab urls not restored after switching to new...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-10 09:19 PST by Tim Horton
Modified: 2014-02-19 12:39 PST (History)
4 users (show)

See Also:

Attachments
patch (11.25 KB, patch)
2014-02-10 10:25 PST, Tim Horton 		darin: review+
Details | Formatted Diff | Diff
patch (3.25 KB, patch)
2014-02-19 11:45 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
flipped a condition (3.25 KB, patch)
2014-02-19 11:53 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-02-10 09:19:36 PST 
http://trac.webkit.org/changeset/162710 changed the WebBackForwardListCF serialization without providing a way to import sessions in the old format.

<rdar://problem/15911839>
Comment 1 Tim Horton 2014-02-10 10:25:05 PST 
Created attachment 223723 [details]
patch
Comment 2 Tim Horton 2014-02-10 17:05:40 PST 
Anders comments that he thinks we should just do the revert of CurrentSessionStateDataVersion and not fail the import if a SnapshotUUID doesn't exist, instead of bumping sessionHistoryCurrentVersion.
Comment 3 Tim Horton 2014-02-19 11:45:30 PST 
Created attachment 224660 [details]
patch
Comment 4 Tim Horton 2014-02-19 11:53:36 PST 
Created attachment 224661 [details]
flipped a condition
Comment 5 WebKit Commit Bot 2014-02-19 12:39:29 PST 
Comment on attachment 224661 [details]
flipped a condition

Clearing flags on attachment: 224661

Committed r164381: <http://trac.webkit.org/changeset/164381>
Comment 6 WebKit Commit Bot 2014-02-19 12:39:32 PST 
All reviewed patches have been landed.  Closing bug.