Bug 128520

Summary: Automatically generate isRendererOfType in RENDER_OBJECT_TYPE_CASTS
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Darin Adler
Reported 2014-02-10 00:32:52 PST
Automatically generate isRendererOfType in RENDER_OBJECT_TYPE_CASTS
Attachments
Patch (19.07 KB, patch)
2014-02-10 00:38 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (20.32 KB, patch)
2014-02-10 07:55 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2014-02-10 00:38:35 PST
Created attachment 223683 [details] Patch
Darin Adler
Comment 2 2014-02-10 07:55:53 PST
Created attachment 223712 [details] Patch
Andreas Kling
Comment 3 2014-02-10 09:21:29 PST
Comment on attachment 223712 [details] Patch r=me Though I wish we could templatize the input too, since that would avoid some bit checks when we have RenderElement instead of RenderObject.
WebKit Commit Bot
Comment 4 2014-02-10 09:53:19 PST
Comment on attachment 223712 [details] Patch Clearing flags on attachment: 223712 Committed r163793: <http://trac.webkit.org/changeset/163793>
WebKit Commit Bot
Comment 5 2014-02-10 09:53:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.