Bug 128516

Summary: [WebGL] Remove state restorer code
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, gyuyoung.kim, kondapallykalyan, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch krit: review+

Dean Jackson
Reported 2014-02-09 21:02:00 PST
I'm not sure what the point of the WebGLStateRestorer class was. It's always constructed with a false parameter, and then isn't even assigned to a local variable so wouldn't have worked anyway. Meanwhile there are also LOTS of calls to cleanupAfterGraphicsCall, the majority of which pass in false, making them a no-op. I replaced the handful of cleanupAfterGraphicsCall(true) with the call to markContextChanged().
Attachments
Patch (54.21 KB, patch)
2014-02-09 21:08 PST, Dean Jackson 		krit: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-09 21:02:30 PST
<rdar://problem/16022970>
Dean Jackson
Comment 2 2014-02-09 21:08:32 PST
Created attachment 223673 [details] Patch
Dirk Schulze
Comment 3 2014-02-09 21:26:07 PST
Comment on attachment 223673 [details] Patch Looks reasonable and definitely cleaner. r=me
Dean Jackson
Comment 4 2014-02-09 21:37:37 PST
Committed r163763: <http://trac.webkit.org/changeset/163763>
Note You need to log in before you can comment on or make changes to this bug.