Bug 128515

Summary: Subpixel layout: Clean up LayoutPoint class.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2014-02-09 20:51:18 PST
Remove redundant functions -keep the explicit functions.
Attachments
Patch (15.44 KB, patch)
2014-02-09 20:54 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (16.44 KB, patch)
2014-02-11 20:13 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2014-02-09 20:54:54 PST
Created attachment 223672 [details] Patch
Jon Lee
Comment 2 2014-02-09 21:40:22 PST
Comment on attachment 223672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223672&action=review > Source/WebCore/platform/graphics/LayoutPoint.h:178 > +inline LayoutPoint flooredLayoutPoint(const FloatSize& s) const FloatPoint&?
alan
Comment 3 2014-02-09 22:14:13 PST
(In reply to comment #2) > (From update of attachment 223672 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223672&action=review > > > Source/WebCore/platform/graphics/LayoutPoint.h:178 > > +inline LayoutPoint flooredLayoutPoint(const FloatSize& s) > > const FloatPoint&? While this is a shortcut for flooredLayoutPoint(toLayoutPoint(s)) and I just moved this particular function around (pretty diff makes it look like it's a newly added function) I can see it is confusing and will remove it.
alan
Comment 4 2014-02-11 20:13:16 PST
Created attachment 223934 [details] Patch
WebKit Commit Bot
Comment 5 2014-02-12 12:29:54 PST
Comment on attachment 223934 [details] Patch Clearing flags on attachment: 223934 Committed r163973: <http://trac.webkit.org/changeset/163973>
WebKit Commit Bot
Comment 6 2014-02-12 12:29:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.