Bug 128515 - Subpixel layout: Clean up LayoutPoint class.
Summary: Subpixel layout: Clean up LayoutPoint class.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-09 20:51 PST by zalan
Modified: 2014-02-12 12:29 PST (History)
6 users (show)

See Also:


Attachments
Patch (15.44 KB, patch)
2014-02-09 20:54 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (16.44 KB, patch)
2014-02-11 20:13 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-02-09 20:51:18 PST
Remove redundant functions -keep the explicit functions.
Comment 1 zalan 2014-02-09 20:54:54 PST
Created attachment 223672 [details]
Patch
Comment 2 Jon Lee 2014-02-09 21:40:22 PST
Comment on attachment 223672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223672&action=review

> Source/WebCore/platform/graphics/LayoutPoint.h:178
> +inline LayoutPoint flooredLayoutPoint(const FloatSize& s)

const FloatPoint&?
Comment 3 zalan 2014-02-09 22:14:13 PST
(In reply to comment #2)
> (From update of attachment 223672 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223672&action=review
> 
> > Source/WebCore/platform/graphics/LayoutPoint.h:178
> > +inline LayoutPoint flooredLayoutPoint(const FloatSize& s)
> 
> const FloatPoint&?

While this is a shortcut for flooredLayoutPoint(toLayoutPoint(s)) and I just moved this particular function around (pretty diff makes it look like it's a newly added function) I can see it is confusing and will remove it.
Comment 4 zalan 2014-02-11 20:13:16 PST
Created attachment 223934 [details]
Patch
Comment 5 WebKit Commit Bot 2014-02-12 12:29:54 PST
Comment on attachment 223934 [details]
Patch

Clearing flags on attachment: 223934

Committed r163973: <http://trac.webkit.org/changeset/163973>
Comment 6 WebKit Commit Bot 2014-02-12 12:29:56 PST
All reviewed patches have been landed.  Closing bug.