Bug 128498 – [GTK] Add API to create a webview related to another one

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

Related web view will shared the same web process. this is needed in some cases, like for window.open(9 but it also allows to implement other multi-process models in the app side.

[Carlos Garcia Campos]

Created attachment 223626 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Gustavo Noronha (kov)]

Comment on attachment 223626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223626&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:653
> +     *
> +     * The related #WebKitWebView used when creating the view to share the
> +     * same web process.
> +     *

We should explain here that you can't obtain the related view after the creation, or is the gtk-doc note for a write-only, consctruct-only property enough, you think (I don't recall seeing one)?

[Carlos Garcia Campos]

(In reply to comment #3)
> (From update of attachment 223626 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223626&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:653
> > +     *
> > +     * The related #WebKitWebView used when creating the view to share the
> > +     * same web process.
> > +     *
> 
> We should explain here that you can't obtain the related view after the creation, or is the gtk-doc note for a write-only, consctruct-only property enough, you think (I don't recall seeing one)?

I assumed that being writable/construct only property and the lack of public getter was clear enough, but I'll add a comment in the docs.

[Carlos Garcia Campos]

Committed r163781: <http://trac.webkit.org/changeset/163781>