Bug 128498 - [GTK] Add API to create a webview related to another one
Summary: [GTK] Add API to create a webview related to another one
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-02-09 03:32 PST by Carlos Garcia Campos
Modified: 2014-02-10 05:42 PST (History)
9 users (show)

See Also:


Attachments
Patch (18.25 KB, patch)
2014-02-09 03:47 PST, Carlos Garcia Campos
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-02-09 03:32:08 PST
Related web view will shared the same web process. this is needed in some cases, like for window.open(9 but it also allows to implement other multi-process models in the app side.
Comment 1 Carlos Garcia Campos 2014-02-09 03:47:17 PST
Created attachment 223626 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-09 03:49:13 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Gustavo Noronha (kov) 2014-02-10 04:43:56 PST
Comment on attachment 223626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223626&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:653
> +     *
> +     * The related #WebKitWebView used when creating the view to share the
> +     * same web process.
> +     *

We should explain here that you can't obtain the related view after the creation, or is the gtk-doc note for a write-only, consctruct-only property enough, you think (I don't recall seeing one)?
Comment 4 Carlos Garcia Campos 2014-02-10 05:37:01 PST
(In reply to comment #3)
> (From update of attachment 223626 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223626&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:653
> > +     *
> > +     * The related #WebKitWebView used when creating the view to share the
> > +     * same web process.
> > +     *
> 
> We should explain here that you can't obtain the related view after the creation, or is the gtk-doc note for a write-only, consctruct-only property enough, you think (I don't recall seeing one)?

I assumed that being writable/construct only property and the lack of public getter was clear enough, but I'll add a comment in the docs.
Comment 5 Carlos Garcia Campos 2014-02-10 05:42:08 PST
Committed r163781: <http://trac.webkit.org/changeset/163781>